Skip to content

chore(rsc): add missing rsc-html-stream dep (fix #857) #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2025
Merged

chore(rsc): add missing rsc-html-stream dep (fix #857) #868

merged 5 commits into from
Sep 17, 2025

Conversation

n9
Copy link
Contributor

@n9 n9 commented Sep 16, 2025

Description

fixes #857

@hi-ogawa hi-ogawa changed the title fix(rsc-sample-ssg): add missing rsc-html-stream dep (fix #857) chore(rsc): add missing rsc-html-stream dep (fix #857) Sep 16, 2025
@n9
Copy link
Contributor Author

n9 commented Sep 16, 2025

@hi-ogawa How to solve this? Should I also modify/commit the global pnpm-lock.yaml in this PR?

@hi-ogawa
Copy link
Contributor

Yes, please pnpm i and then commit.

@n9
Copy link
Contributor Author

n9 commented Sep 16, 2025

@hi-ogawa Done.

FYI: I do not commit these changes:

+++ b/pnpm-lock.yaml
@@ -5973,7 +5973,7 @@ snapshots:
 
   '@img/[email protected]':
     dependencies:
-      '@emnapi/runtime': 1.4.5
+      '@emnapi/runtime': 1.5.0
     optional: true
 
   '@img/[email protected]':
@@ -6216,7 +6216,7 @@ snapshots:
 
   '@rolldown/[email protected]':
     dependencies:
-      '@napi-rs/wasm-runtime': 1.0.3
+      '@napi-rs/wasm-runtime': 1.0.5
     optional: true
 
   '@rolldown/[email protected]':

hi-ogawa
hi-ogawa approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hi-ogawa hi-ogawa merged commit c30cf1a into vitejs:main Sep 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing rsc-html-stream in package.json of plugin-rsc/samples/ssg
2 participants
@n9 @hi-ogawa